[PATCH] D118122: [WebAssembly] Refactor and fix emission of external IR global decls

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Sadly this appears to also be breaking the emscripten CI:

https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8823500584349280721/overview

Sample failure:

  test_unistd_unlink (test_core.core0) ... 
  wasm-ld: error: symbol type mismatch: __stdio_write
  >>> defined as WASM_SYMBOL_TYPE_FUNCTION in /usr/local/google/home/sbc/dev/wasm/emscripten/cache/sysroot/lib/wasm32-emscripten/libc-debug.a(__stdio_write.o)
  >>> defined as WASM_SYMBOL_TYPE_DATA in /usr/local/google/home/sbc/dev/wasm/emscripten/cache/sysroot/lib/wasm32-emscripten/libc-debug.a(stderr.o)

I guess we should revert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118122/new/

https://reviews.llvm.org/D118122