[PATCH] D117951: [SLP] Optimize reschedule of previously scheduled bundle member [NFC]

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2599
+    void unschedule(ScheduleData *SD) {
+      assert(SD && SD->isSchedulingEntity() && SD->IsScheduled);
+      LLVM_DEBUG(dbgs() << "SLP:   unschedule " << *SD << "\n");
----------------
reames wrote:
> ABataev wrote:
> > reames wrote:
> > > ABataev wrote:
> > > > Asserting message?
> > > Doesn't seem to add any value and we are inconsistent about them across codebase.
> > > 
> > > I really don't care here, if you want it added, please give me wording and I'll copy-and-paste.  
> > We try to add messages in a new/modified code.
> This is not in the programming manual.  I checked.
Though, I apparently didn't check hard enough.  It is in the style guide.  Hm, wonder when that changed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117951/new/

https://reviews.llvm.org/D117951