[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

Mon Jan 31 12:06:37 PST 2022

jmorse added a comment.

Sitrep on this:

- I've added a cut-off in D118601 <https://reviews.llvm.org/D118601> that limits max-rss growth in the sample from @alexfh to "only" about 12%, which given its autogenerated nature, seems reasonable to me. I've got some scripts working out what the cut-off value would be for some LTO builds of large codebases, I think the best plan is "pick a reasonable number and double it".
- Other patches in the related (largely approvedish) stack address most of the growth in max-rss for CTMark, although it still goes up by 10% for SPASS. That's in a function with 220k instructions, 50k of which are DBG_VALUEs, 90k DBG_VALUEs with instr-ref.
- On the performance front, the regression in compile-time is now down to less than 2% geomean [0], there are still one or two tricks I can pull.

However I'm out of the (figurative) office for most of tomorrow, so not all of this is going to hit by branch time. I'll wave the situation in Tom Stellards direction and see what happens.

[0] http://llvm-compile-time-tracker.com/compare.php?from=30efee764d95d425b480758ed02682fab6426d28&to=2de5ce8245a00d52e397057d5976d89f3002220d&stat=instructions

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821