[PATCH] D118604: [RS4GC] Make PointerToBase mapping be global. NFC.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 11:20:34 PST 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM, though can you update the commit comment not to call this "global"?  That generally makes me thing global variable (i.e. static at TU level), not global to the function.

Once this lands, I think there might be some further cleanup available.  But that can be done lazily as needed.

I'm somewhat shaking my head that we never noticed the reuse potential before.  Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118604/new/

https://reviews.llvm.org/D118604



More information about the llvm-commits mailing list