[PATCH] D108416: [llvm-libgcc] initial commit

Christopher Di Bella via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 10:39:57 PST 2022


cjdb added inline comments.


================
Comment at: llvm/tools/llvm-libgcc/lib/gcc_s.ver:20
+#if defined(ARM_GNUEABIHF) || defined(__i386__)
+  #define GLOBAL_32BIT
+#endif
----------------
MaskRay wrote:
> `__LP64__`
> 
> Unsure anyone will use this for ILP64. Sticking with LP64 and `!__LP64__` should be fine.
Eh, it's not that much extra work to support it, especially if we use `#else` on the tail of 64-bit detection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108416/new/

https://reviews.llvm.org/D108416



More information about the llvm-commits mailing list