[PATCH] D118603: [DAGCombine] Add simple folds for SSHLSAT/USHLSAT

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 09:37:48 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9357
+  if (SDValue V = DAG.simplifyShift(N0, N1))
+    return V;
+
----------------
Do you have any test coverage for undef/poison/outofrangeamt operands - that's mainly what simplifyShift handles?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118603/new/

https://reviews.llvm.org/D118603



More information about the llvm-commits mailing list