[PATCH] D118597: [DebugInfo][InstrRef][NFC] Don't build mappings of values to locations for un-needed values

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Nice! I have one question inline but this SGTM.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:323
       auto ValuesPreferredLoc = ValueToLoc.find(Num);
-      if (ValuesPreferredLoc == ValueToLoc.end()) {
+      if (ValuesPreferredLoc == ValueToLoc.end() ||
+          ValuesPreferredLoc->second.isIllegal()) {
----------------
Hmm... can `ValuesPreferredLoc == ValueToLoc.end()` ever be true now, with this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118597/new/

https://reviews.llvm.org/D118597