[PATCH] D118529: [ELF] Rename adjustSectionsBeforeSorting to adjustOutputSections and make it affect INSERT commands

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Would it be possible to go a bit further and move all the functionality from `adjustSections` that isn't important for placing Orphan Sections to `adjustSectionsAfterSorting`. We'd then be able to give `adjustSections` a more specific name. For example `adjustOutputSectionFlags`. As it stands `adjustSections` could mean almost anything.

No objections to the work done so far though.



================
Comment at: lld/ELF/LinkerScript.cpp:1169
     //            .foo : { *(.foo) } }
     // Note: at this point the order of output sections has not been finalized,
     // because orphans have not been inserted into their expected positions. We
----------------
I'm not sure I understand the edit here. The function we are in is adjustOutputSections() and it is not called again. There is an adjustSectionsAfterSorting that is called after Orphans are placed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118529/new/

https://reviews.llvm.org/D118529