[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added inline comments.


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1771
+    SmallString<128> SectionName(
+        {".llvm.offloading.", std::get<1>(FilenameAndSection)});
+    llvm::EmbedBufferInModule(*M, **ObjectOrErr, SectionName);
----------------
OK, so on failure to parse (missing comma?), this will be an empty string, and the section created will be `.llvm.offloading.`. Given that sections with the same name are implicitly concatenated that's a sharp edge, can we fatal error on the second field being empty? It indicate a badly formed commandline argument of some sort


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116542/new/

https://reviews.llvm.org/D116542