[PATCH] D118534: [X86] Introduce more common modern tunings into `generic`

Mon Jan 31 06:01:58 PST 2022

pengfei added inline comments.

================
Comment at: llvm/test/CodeGen/X86/twoaddr-lea.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc < %s -mcpu=generic -mtriple=x86_64-apple-darwin | FileCheck %s
+; RUN: llc < %s -mcpu=x86-64 -mtriple=x86_64-apple-darwin | FileCheck %s

----------------
RKSimon wrote:
> not sure about -mcpu here - we do have some variation in use of lea depending on tuning - maybe we need more -mcpu coverage?
Here the generated code is affected by tuning `TuningSlowIncDec`.
I think we should prefer to using `-mcpu=x86-64` rather than `generic` in lit tests since we might update the tunings of `generic` in future.
We have more than 100 lines of RUNs with it, we may need a seperate patch to replace them. But the diff here is OK to reflect the change on tunings.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118534/new/

https://reviews.llvm.org/D118534