[PATCH] D118530: [ELF] Update flag propagation rule to ignore discarded output sections

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.

LGTM too.



================
Comment at: lld/ELF/LinkerScript.cpp:1153
+    bool discardable = isEmpty && isDiscardable(*sec);
+    // If sec has at least an input section and not discarded, remember its
+    // flags to be inherited by subsequent output sections. (sec may contain
----------------
Trivial language nit, suggest one instead of an. // If sec has at least one input section and is not discarded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118530/new/

https://reviews.llvm.org/D118530