[PATCH] D118443: Add support for atomic memory copy lowering

Mon Jan 31 05:03:49 PST 2022

ebrevnov added inline comments.

================
Comment at: llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp:513
+template<typename T>
+static bool canOverlap(MemTransferBase<T> *Memcpy, ScalarEvolution *SE) {
   if (SE) {
----------------
yurai007 wrote:
> nit: is there any reason for templating first parameter? For now we only pass concrete MemCpyInst as argument.
Oh, you are right... Originally, there was call to canOverlap from expandAtomicMemCpyAsLoop passing AtomicMemCpyInst. Later I realized that this call is not required. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118443/new/

https://reviews.llvm.org/D118443