[PATCH] D118454: [DebugInfo][InstrRef][NFC] Refactor code portions into own functions, name some useful types

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

The clang-format bot isn't happy and I have one nit inline, otherwise LGTM.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:998-1001
+  /// Produce a set of blocks that are in the current lexical scope. Exactly
+  /// what constitutes "in scope" can be open to interpretation -- for example,
+  /// we can assign variable values in blocks that aren't in lexical scope.
+  /// Thus, it's best to put this in its own function.
----------------
Is there a way that you could reword this to make it slightly clearer what your chosen definition of "in scope" is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118454/new/

https://reviews.llvm.org/D118454