[PATCH] D118451: Save some `std::string` allocations/deallocations when formatting attributes (NFC)

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 04:21:19 PST 2022


chill added a comment.

In D118451#3279854 <https://reviews.llvm.org/D118451#3279854>, @MaskRay wrote:

> Thanks! I suspect `'x'` may compile to less code than `"x"` :)

Well, yeah, but `operartor+` does not have the needed overloads and while I casually care about heap allocations, I'd like to have a specific reason for loading a `char` vs. loading the address of a string literal
before bothering to add those overloads :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118451/new/

https://reviews.llvm.org/D118451



More information about the llvm-commits mailing list