[PATCH] D118249: [demangler] remove StdQualifiedName
Nathan Sidwell via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 31 03:54:51 PST 2022
urnathan added a comment.
In D118249#3281281 <https://reviews.llvm.org/D118249#3281281>, @ChuanqiXu wrote:
> In D118249#3279254 <https://reviews.llvm.org/D118249#3279254>, @urnathan wrote:
>
>>
>>> Yeah, but it looks like StdQualifiedName is deleted completely...
>>
>> Yes. That is the intent.
>
> I got your point. hmmm I think such rewriting would make the code harder to read. Is it possible to use StdQualifiedName to replace NestedName (std, ...)?
I'm sorry I disagree. I see no reason to special-case '::std' in this way, and doing so makes the code harder to read --we'd keep having to check if a name is ::std. Let's pick one way to represent nested names.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118249/new/
https://reviews.llvm.org/D118249
More information about the llvm-commits
mailing list