[PATCH] D118534: [X86] Introduce more common modern tunings into `generic`

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:1518
   TuningMacroFusion,
   TuningInsertVZEROUPPER
 ]>;
----------------
We now diverge from the x86-64 tuning flags - maybe make it clear in the comments for the generic model?


================
Comment at: llvm/test/CodeGen/X86/rdtsc-upgrade.ll:3
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mcpu=x86-64 | FileCheck %s --check-prefix=X86
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=x86-64 | FileCheck %s --check-prefix=X64
 
----------------
do we even need to specificy -mcpu here?


================
Comment at: llvm/test/CodeGen/X86/rdtsc.ll:3
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mcpu=x86-64 | FileCheck %s --check-prefix=X86
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=x86-64 | FileCheck %s --check-prefix=X64
 
----------------
do we really need -mcpu?


================
Comment at: llvm/test/CodeGen/X86/twoaddr-lea.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc < %s -mcpu=generic -mtriple=x86_64-apple-darwin | FileCheck %s
+; RUN: llc < %s -mcpu=x86-64 -mtriple=x86_64-apple-darwin | FileCheck %s
 
----------------
not sure about -mcpu here - we do have some variation in use of lea depending on tuning - maybe we need more -mcpu coverage?


================
Comment at: llvm/test/tools/llvm-mca/X86/cv_fpo_directive_no_segfault.s:2
 # NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py
-# RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=generic -resource-pressure=false -instruction-info=false < %s | FileCheck %s
+# RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -resource-pressure=false -instruction-info=false < %s | FileCheck %s
 
----------------
@andreadb what test coverage do we need here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118534/new/

https://reviews.llvm.org/D118534