[PATCH] D118122: [WebAssembly] Refactor and fix emission of external IR global decls

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 00:13:10 PST 2022


pmatos added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:270
+  if (!WasmTy)
+    return;
+
----------------
sbc100 wrote:
> Does this happen?  i.e. are there symbols that don't have their type set at this point?
Yes, just set a breakpoint on the return line (270) and run `simd-arith.ll` and you'll see a few cases of this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118122/new/

https://reviews.llvm.org/D118122



More information about the llvm-commits mailing list