[PATCH] D118415: AMDGPU: Reserve v32 if we may need to copy between AGPRs on gfx908

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D118415#3278061 <https://reviews.llvm.org/D118415#3278061>, @arsenm wrote:

> In D118415#3277958 <https://reviews.llvm.org/D118415#3277958>, @rampitec wrote:
>
>> Anyway, inability to run kernels at maximum occupancy is a show stopper itself.
>
> This is practically impossible if you are using mfma instructions anyway

This might be OK, but consider two things: 1) you are not checking agprs are unused (easy to fix) 2) there are some mfma instructions which only need a128. I don't believe there are kernels which fit that budget, but I cannot blidnly deny it too.

I.e. I would prefer to fail compilation rather than reserving v32.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118415/new/

https://reviews.llvm.org/D118415