[PATCH] D118419: [AMDGPU] Allow scalar loads after barrier

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked 2 inline comments as done.
rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:80
+
+  LLVM_DEBUG(dbgs() << "Checking clobbering of: " << *Load << '\n');
+
----------------
arsenm wrote:
> Don't need extra new line
It is not extra. This is the actual output on my console:

```
Checking clobbering of:   %i2 = load i32, i32 addrspace(1)* %i1, align 4, !tbaa !15
  Def:   fence syncscope("workgroup") acquire
  Def:   tail call void @llvm.amdgcn.s.barrier() #3
  Def:   fence syncscope("workgroup") release
      -> no clobber
```


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:93
+
+      LLVM_DEBUG(dbgs() << "  Def: " << *DefInst << '\n');
+
----------------
arsenm wrote:
> Don't need extra newline
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118419/new/

https://reviews.llvm.org/D118419