[PATCH] D118281: Rename llvm::array_lengthof into llvm::size

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 13:19:50 PST 2022


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/ADT/STLForwardCompat.h:79
+}
+
 //===----------------------------------------------------------------------===//
----------------
Because we already have a llvm::size in STLExtras and it'll remain there after we adopt a new standard, I'm not sure about introducing these right now: we won't be able to remove then and mass-update the uses with a textual replacement (it'd match the users of the STLExtras variant).

Considering this, what is the motivation to rename array_lengthof right now instead of waiting for LLVM to move to C++17?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118281/new/

https://reviews.llvm.org/D118281



More information about the llvm-commits mailing list