[PATCH] D117253: [AMDGPU] Select VGPR versions of MFMA if possible
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 26 16:20:23 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:4258
+ const SIMachineFunctionInfo *Info = MF.getInfo<SIMachineFunctionInfo>();
+ OpdsMapping[0] =
+ Info->mayNeedAGPRs()
----------------
Doesn't this need a subtarget check?
================
Comment at: llvm/lib/Target/AMDGPU/VOP3PInstructions.td:448
+class AgprMAIFrag<SDPatternOperator Op> :
+ MAIFrag<Op, [{ return MF->getInfo<SIMachineFunctionInfo>()->mayNeedAGPRs(); }]>;
+
----------------
The point of checking it here is you don't need to inspect the original IR. You can check if there are any AGPR uses in the machine function
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117253/new/
https://reviews.llvm.org/D117253
More information about the llvm-commits
mailing list