[PATCH] D118534: [X86] Introduce more common modern tunings into `generic`

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 30 17:16:48 PST 2022


pengfei added a comment.

In D118534#3282808 <https://reviews.llvm.org/D118534#3282808>, @lebedev.ri wrote:

> In D118534#3282807 <https://reviews.llvm.org/D118534#3282807>, @spatel wrote:
>
>> In D118534#3282197 <https://reviews.llvm.org/D118534#3282197>, @pengfei wrote:
>>
>>> As I read the comments in D117912 <https://reviews.llvm.org/D117912>, the changes in default tuning should solve the problem. Do I miss something else?
>>> I saw some attempts on using `x86-64-v2`, e.g., RHEL 9 <https://developers.redhat.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level>. But I think it's still aggressive to use it as default target in compiler, not to mention `x86-64-v3`.
>>
>> I might have misunderstood the requirements, but I thought we won't get the ideal performance on the benchmark unless we can generate `tzcnt` without explicitly specifying the default CPU arch.
>
> That would require bumping what ISA's are implied by `generic`, yes.

I see. Yes, we can do nothing with it currently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118534/new/

https://reviews.llvm.org/D118534



More information about the llvm-commits mailing list