[PATCH] D118570: [lld-macho] Add support for -image_base, -static, -pagezero_size, and -version_load_command

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

Thanks for the contribution :)

You should add tests for all of these changes. Our tests are in lld/test/MachO <https://github.com/llvm/llvm-project/tree/main/lld/test/MachO>. If you haven't worked with LLVM's test system before, there's overviews of lit <https://llvm.org/docs/CommandGuide/lit.html>, FileCheck <https://llvm.org/docs/CommandGuide/FileCheck.html>, and a general testing guide <https://llvm.org/docs/TestingGuide.html>. `check-lld-macho` is the build target for our tests.

I'll let others take a look at the code changes in detail, but the high-level idea seems good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118570/new/

https://reviews.llvm.org/D118570