[PATCH] D118547: [OMPIRBuilder] Add support for atomic compare

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 30 13:34:56 PST 2022


jdoerfert added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3487
+           "OMP atomic expects a pointer to target memory");
+    Type *XElemTy = XTy->getPointerElementType();
+    assert((XElemTy->isFloatingPointTy() || XElemTy->isIntegerTy() ||
----------------
nikic wrote:
> Should be `X.ElemTy`.
I have to start paying attention to the getPointerElementType uses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118547/new/

https://reviews.llvm.org/D118547



More information about the llvm-commits mailing list