[PATCH] D118572: [NewGVN] Improve phi-of-ops fix to allow loads that loop invariant-ish

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 30 11:11:37 PST 2022


nlopes created this revision.
nlopes added reviewers: asbirlea, fhahn.
Herald added subscribers: bollu, hiraditya.
nlopes requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

My previous fix for the phi-of-ops was a bit of a big hammer.
This patch uses Memory SSA to detect when a load is guaranteed to not depend on a store that may happen inside the loop.

This patch fixes the regression in storeoverstore.ll, where the big hammer had disabled phi-of-ops for this test case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118572

Files:
  llvm/lib/Transforms/Scalar/NewGVN.cpp
  llvm/test/Transforms/NewGVN/phi-of-ops-loads.ll
  llvm/test/Transforms/NewGVN/storeoverstore.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118572.404400.patch
Type: text/x-patch
Size: 7946 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220130/b22a9ae0/attachment-0001.bin>


More information about the llvm-commits mailing list