[PATCH] D118346: [ORC] Support ADR_PREL_PG_HI21 & ADD_ABS_LO12_NC for aarch64

Yifeng Dong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 30 00:45:04 PST 2022


dongAxis1944 added a comment.

In D118346#3281579 <https://reviews.llvm.org/D118346#3281579>, @lhames wrote:

> Reviewing the patch as-is because I think it's a great addition. If work on the ELF/aarch64 backend is starting in earnest though I would prefer to create a new generic aarch64.h header (along the lines of riscv.h and x86_64.h) and populate it with the existing MachO relocations -- the fixup logic is generally sharable, so there shouldn't be any need to duplicate it, though ELF will probably require some extra relocations beyond the set MachO uses.
>
> If that sounds good to you I'll try to find some time to do that next week.

thanks for reviewing. I actually run the test locally, but I will rerun it again and find out the errors.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118346/new/

https://reviews.llvm.org/D118346



More information about the llvm-commits mailing list