[PATCH] D114841: [lld-macho] Fix duplicate symbols with relocatable objects

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 29 11:52:16 PST 2022


oontvoo accepted this revision.
oontvoo added a comment.

lg thanks! (please run clang-format )



================
Comment at: lld/test/MachO/framework-object.ll:5
+; RUN: mkdir -p %t/Foo.framework
+; RUN: llc --filetype=obj %t/framework.ll -o %t/Foo.framework/Foo
+; RUN: llc --filetype=obj %t/load-framework-foo.ll -o %t/main
----------------
keith wrote:
> oontvoo wrote:
> > llvm-mc
> > 
> Are you saying I should rewrite this to use asm for this case instead? Or is there some version of that command that can do this same conversion? AFAICT if the source is either, I have to use multiple tools to get an object one time, and bitcode the other time.
actually ignore this - I'd previously thought `llc` wasn't on the list of available tools for test, hence I was suggesting using llvm-mc instead. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114841/new/

https://reviews.llvm.org/D114841



More information about the llvm-commits mailing list