[PATCH] D114275: [lld-macho] Improve LC_FUNCTION_STARTS test coverage (NFC)

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 29 11:34:27 PST 2022


oontvoo added a comment.

In D114275#3281196 <https://reviews.llvm.org/D114275#3281196>, @keith wrote:

> It looks like the logic change from this was committed in https://reviews.llvm.org/D110040, @oontvoo was that intentional or did it sneak in since you tested this? I think we were good to go here, so I'll update this to just include the test, just wanted to make sure I followed what happened

Sorry, I'm a bit confused. D110040 <https://reviews.llvm.org/D110040> was from Sept 2021. This patch was ~Nov 2021.  (furthermore D110040 <https://reviews.llvm.org/D110040> was about the lazy personality symbol, whereas this patch involves the synthetic symbols.)
perhaps quoting the wrong patch? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114275/new/

https://reviews.llvm.org/D114275



More information about the llvm-commits mailing list