[PATCH] D118122: [WebAssembly] Refactor and fix emission of external IR global decls

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

lgtm % comments



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:367
-void WebAssemblyAsmPrinter::emitEndOfAsmFile(Module &M) {
-  emitExternalDecls(M);
 
----------------
I guess this was here to handle the case that emitLinkage was never called?   Does that not apply to emitConstantPool too?  

In other words, why remove this line?



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:270
+  if (!WasmTy)
+    return;
+
----------------
Does this happen?  i.e. are there symbols that don't have their type set at this point?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118122/new/

https://reviews.llvm.org/D118122