[PATCH] D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull.

[Sunho Kim via Phabricator via llvm-commits]

sunho marked 4 inline comments as done.
sunho added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/neon-vmull-high-p8.ll:8
+
+define <8 x i16> @test_pmull2_sink(<16 x i8> %a, <16 x i8> %b, <8 x i16> %c, i1 %t) {
+entry:
----------------
fhahn wrote:
> it would also be good to add a few negative tests, where sinking won't happen, e.g. because there are users in other blocks. Also cases where the other or both shuffles need sinking.
When would sinking not happen? I've read the code, but it seems it's always sinking unless the operand is phi nod .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117944/new/

https://reviews.llvm.org/D117944