[PATCH] D113442: [InstCombine] Enable fold select into operand for FAdd,  FMul, FSub and FDiv.
    LuoYuanke via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sat Jan 29 06:37:26 PST 2022
    
    
  
LuoYuanke added a comment.
This patch cause regression (https://godbolt.org/z/7WYboTe16) when x86 avx512 target, because avx512 has mask instruction which can match select instruction in ISel pattern match. Move select before fadd cause the pattern match fails. I don't quite understand for the optimization opportunity for this transformation. Could you elaborate an example for it?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113442/new/
https://reviews.llvm.org/D113442
    
    
More information about the llvm-commits
mailing list