[PATCH] D108416: [llvm-libgcc] initial commit

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-libgcc/lib/gcc_s.ver:16
+#if defined(__x86_64__) || defined(__i386__)
+  #define GLOBAL_X86
+#endif
----------------
You may use `__LP64__`


================
Comment at: llvm/tools/llvm-libgcc/lib/gcc_s.ver:20
+#if defined(ARM_GNUEABIHF) || defined(__i386__)
+  #define GLOBAL_32BIT
+#endif
----------------
`__LP64__`

Unsure anyone will use this for ILP64. Sticking with LP64 and `!__LP64__` should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108416/new/

https://reviews.llvm.org/D108416