[PATCH] D118249: [demangler] remove StdQualifiedName

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D118249#3279254 <https://reviews.llvm.org/D118249#3279254>, @urnathan wrote:

> In D118249#3278121 <https://reviews.llvm.org/D118249#3278121>, @ChuanqiXu wrote:
>
>> In D118249#3275622 <https://reviews.llvm.org/D118249#3275622>, @urnathan wrote:
>>
>>> No, sorry for being unclear.
>>>
>>> std::name (St4Name)-> we would use StdQualifiedName
>>> std::name1::name2 (NSt5Name15Name2E)-> we would use NestedName (std, ...)
>>> std::name1<Inst> (NSt5Name1I4InstEE)-> we would also use NestedName (std, ...)
>>>
>>> this patch moves to using NestedName in all these cases.  (The other substitutions, such as 'Sa' remain unchanged)
>>
>> Yeah, but it looks like StdQualifiedName is deleted completely...
>
> Yes.  That is the intent.

I got your point. hmmm I think such rewriting would make the code harder to read. Is it possible to use StdQualifiedName to replace  NestedName (std, ...)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118249/new/

https://reviews.llvm.org/D118249