[PATCH] D118517: [BOLT][DWARF] Handle shared abbrev section

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 28 17:05:19 PST 2022


Amir added a comment.

Is the input `bolt/test/X86/Inputs/dwarfdump-gdbindex-v7.elf-x86-64.yaml` still used?



================
Comment at: bolt/include/bolt/Core/DebugData.h:725
+  /// Map from Hash Signature to AbbrevData.
+  std::unordered_map<std::string, std::unique_ptr<AbbrevData>> AbbrevDataCache;
 
----------------
Better to use `llvm::StringMap` in this case. It probably doesn't remove the need for llvm::SHA1 Hasher: StringMap will hash the key internally, but still store it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118517/new/

https://reviews.llvm.org/D118517



More information about the llvm-commits mailing list