[llvm] 746e435 - Revert "[SLP] Add a clarifying assert in block scheduling [NFC]"

[Philip Reames via llvm-commits]

Author: Philip Reames
Date: 2022-01-28T12:10:31-08:00
New Revision: 746e435ff76a12468103a978d46f7b1a5052e867

URL: https://github.com/llvm/llvm-project/commit/746e435ff76a12468103a978d46f7b1a5052e867
DIFF: https://github.com/llvm/llvm-project/commit/746e435ff76a12468103a978d46f7b1a5052e867.diff

LOG: Revert "[SLP] Add a clarifying assert in block scheduling [NFC]"

This reverts commit db49a78900f5e4b59714565876b5dbb5e2dfe840.  The reasoning in the patch applied to a downstream branch, and I got myself confused when trying to split apart pieces.  Thankfully, the assert was simply weaker than the actual invariant currently upstream which is that ReadyInsts is not empty.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 84d00d50e7bc8..967e527b16d51 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -7668,11 +7668,6 @@ void BoUpSLP::scheduleBlock(BlockScheduling *BS) {
   }
   BS->initialFillReadyList(ReadyInsts);
 
-  assert((!ReadyInsts.empty() ||
-          (VectorizableTree.size() == 1 &&
-           VectorizableTree[0]->State == TreeEntry::NeedToGather)) &&
-         "why no ready insts from scheduleable tree?");
-
   Instruction *LastScheduledInst = BS->ScheduleEnd;
 
   // Do the "real" scheduling.