[PATCH] D118214: [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.

[Ahmed Bougacha via Phabricator via llvm-commits]

ab added a comment.

In D118214#3274486 <https://reviews.llvm.org/D118214#3274486>, @ahatanak wrote:

> Are there any users who need the changes in autoupgrade? `clang.arc.attachedcall` bundles without operands are emitted only after ARC contract (ARC optimizer does't remove the operand), so it seems safe not to upgrade the IR.

That's an interesting point.  I looked for where the pass was inserted in the pipeline, and I thought it did run in the frontend when doing LTO, but digging a bit more, it sounds like it really only is before the backend, with or without LTO.  So I think you're right, we don't need this after all!  (and hopefully there are no non-clang users of the bundle with different expectations).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118214/new/

https://reviews.llvm.org/D118214