[PATCH] D118490: [lld][ELF] add .note sections from linker scripts as SHT_NOTE

Fri Jan 28 10:07:18 PST 2022

bluca added a comment.

In D118490#3280046 <https://reviews.llvm.org/D118490#3280046>, @MaskRay wrote:

> Not very comfortable with this. I think GNU ld has other rules in this area and I am not sure we want to follow them all.
> Can you file a feature request on https://sourceware.org/bugzilla/ to add a way to specify the output section type? https://sourceware.org/binutils/docs/ld/Output-Section-Type.html#Output-Section-Type

Hi,

The problem is that breaks compatibility with bfd the other way around, because there's no such specifier there. For the linked feature ( https://fedoraproject.org/wiki/Changes/Package_information_on_ELF_objects ), we have a distro-wide linker script that we need to use for all builds. It's not really doable to do per-build-dependency generation, it's hard enough as it is. We need full compatibility.

Also, isn't compatibility with input supported by bfd a project goal? If you take the linker script I added as a test and run it through bfd and lld, they'll generate different and incompatible outputs that breaks tools like systemd-coredump.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118490/new/

https://reviews.llvm.org/D118490