[PATCH] D114737: [lld][Macho] Include dead-stripped symbols in mapfile

[Roger Kim via Phabricator via llvm-commits]

Roger added inline comments.


================
Comment at: lld/test/MachO/dead-strip.s:61
+# RUN:     %t/no-dead-symbols.s -o %t/no-dead-symbols.o
+# RUN: %lld -lSystem -dead_strip -map %t/map \
+# RUN:     %t/no-dead-symbols.o -o %t/no-dead-symbols
----------------
int3 wrote:
> can we call this file something other than `map`? That way we're not overwriting the `map` emitted by the earlier command on line 11. That makes debugging the test easier since we can look in the output folder and see the preserved outputs from each command.
Done.


================
Comment at: lld/test/MachO/dead-strip.s:72
+# NODEADSYMBOLS-NEXT: # Address File Name
+# NODEADSYMBOLS-NEXT: END OF MAP
 
----------------
int3 wrote:
> this could just be `NODEADSYMBOLS-EMPTY:`, then you wouldn't need the "END OF MAP"
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114737/new/

https://reviews.llvm.org/D114737