[PATCH] D118469: [SVE] Remove AArch64ISD::PFALSE.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

In D118469#3279467 <https://reviews.llvm.org/D118469#3279467>, @david-arm wrote:

> Hi @paulwalker-arm, you mentioned that "it can prevent common combines from firing". I don't suppose you've got any examples of such cases at all? If not, then don't worry. The patch looks good anyway!

I've nothing specific but it was D118147 <https://reviews.llvm.org/D118147> that promoted this patch as it needed extra code to account for this other representation of zero.  My hope is that after the obvious `REINTERPRET_CAST 0 -> 0` fold we'd get such select optimisations for free.  I'm also thinking it might be worth having similar behaviour for all_true (i.e. maintain the splat_vector instead of using PTRUE) but that requires more thought.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118469/new/

https://reviews.llvm.org/D118469