[PATCH] D118218: [RISCV] Pre-commit test for D118216
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 28 06:41:12 PST 2022
asb added a comment.
Although it's a bit repetitive, we typically try to run tests with both riscv32 and riscv64 if possible. It looks like this test case actually has identical assembly for RV32 and RV64, so you can just add a second CHECK line and leave them both using the default 'CHECK' prefix.
It would also be helpful to add a comment to the file explaining what it's trying to test. e.g. "This test case checks whether the address of an array is repeatedly rematerialised within a loop.".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118218/new/
https://reviews.llvm.org/D118218
More information about the llvm-commits
mailing list