[PATCH] D118463: [SVE] By using SEL when orring predicates we forgo the need for a PTRUE.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 28 06:21:05 PST 2022


sdesmalen added a comment.

In D118463#3279311 <https://reviews.llvm.org/D118463#3279311>, @paulwalker-arm wrote:

> In D118463#3279299 <https://reviews.llvm.org/D118463#3279299>, @sdesmalen wrote:
>
>> Hi @paulwalker-arm, just an FYI that this needs rebasing after D118146 <https://reviews.llvm.org/D118146> where I did something similar for `and`.
>
> This already builds on your great work, see how I'm reusing your sve_int_pred_log_and class, although have renamed it now it has other uses.

Ah I see it now. I hadn't yet pulled 49178a2c4ee3f44b85d99c3730a7e71e2caf554a <https://reviews.llvm.org/rG49178a2c4ee3f44b85d99c3730a7e71e2caf554a> so things still looked different from my local repo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118463/new/

https://reviews.llvm.org/D118463



More information about the llvm-commits mailing list