[PATCH] D118454: [DebugInfo][InstrRef][NFC] Refactor code portions into own functions, name some useful types

[Jeremy Morse via Phabricator via llvm-commits]

jmorse created this revision.
jmorse added reviewers: StephenTozer, Orlando, TWeaver.
Herald added subscribers: mgrang, hiraditya.
jmorse requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch shuffles some functions around before another patch that uses them, so this is primarily a refactor. In particular:

- Move the determination of "which blocks are in scope" to its own function -- this is sometimes trickier than it sounds, and we're going to end up doing it twice. In the process, the "InScopeBlocks" collection is deleted, nothing actually read it, I believe it's a hangover from VarLocBasedLDV.
- Split transfer emission (i.e., installing DBG_VALUEs into blocks) into its own function.
- Give type names to a variety of useful collections that are going to be used in several places shortly.
- Rename a misleading name, "ScopeToBlocks" to "ScopeToAssignBlocks". Because it stores a collection of blocks where assignments happen, not the set of blocks for a scope.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118454

Files:
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118454.403968.patch
Type: text/x-patch
Size: 14489 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220128/a39012a7/attachment.bin>