[PATCH] D118121: [WebAssembly] Refactor WasmSymbol type setting code

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 28 03:32:28 PST 2022


pmatos added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp:20
+#include "Utils/WebAssemblyTypeUtilities.h"
 #include "Utils/WebAssemblyUtilities.h"
 #include "WebAssembly.h"
----------------
sbc100 wrote:
> Are both WebAssemblyUtilities.h and WebAssemblyTypeUtilities.h needed here?
Yes, WebAssemblyUtilities.h is still needed for `getOrCreateFunctionTableSymbol`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118121/new/

https://reviews.llvm.org/D118121



More information about the llvm-commits mailing list