[PATCH] D118430: [RISCV] Custom legalize BITREVERSE with Zbkb.

Xinlong Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 22:42:17 PST 2022


VincentWu added a comment.





================
Comment at: llvm/test/CodeGen/RISCV/bswap-bitreverse.ll:850
+; RV32ZBKB:       # %bb.0:
+; RV32ZBKB-NEXT:    rev8 a0, a0
+; RV32ZBKB-NEXT:    srli a0, a0, 16
----------------
craig.topper wrote:
> We need some more DAG combines to improve this.
> We need some more DAG combines to improve this.

Will you continue to update this patch? or put it later

if put it later. what about add an `// TODO:` comment in the proper place.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118430/new/

https://reviews.llvm.org/D118430



More information about the llvm-commits mailing list