[PATCH] D118189: [llvm-objcopy][COFF] Implement --update-section

Thu Jan 27 21:42:33 PST 2022

abrachet marked 8 inline comments as done.
abrachet added a comment.

Thanks for the review @MaskRay

In D118189#3278244 <https://reviews.llvm.org/D118189#3278244>, @MaskRay wrote:

> I agree it'd be great to let @jhenderson have a look at it, but seem fine to catch up the 14.x branch and address other issues.

Yes I'll wait for James. Theres no rush on my end to get this in before llvm 14.

================
Comment at: llvm/test/tools/llvm-objcopy/COFF/update-section.test:69
+    SizeOfRawData:   0
+symbols:
+...
----------------
MaskRay wrote:
> delete unused `symbols:`
Looks like I can't `error: missing required key 'symbols'`

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118189/new/

https://reviews.llvm.org/D118189