[PATCH] D118189: [llvm-objcopy][COFF] Implement --update-section

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

I agree it'd be great to let @jhenderson have a look at it, but seem fine to catch up the 14.x branch and address other issues.



================
Comment at: llvm/test/tools/llvm-objcopy/COFF/update-section.test:37
+# MULTIPLE:       RawDataSize: 4
+# MULTIPLE: Hex dump of section '.text':
+# MULTIPLE-NEXT: 0x00000000 41414142 AAAB
----------------
`Hex dump of section '.text':` should be aligned, too.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/update-section.test:48
+
+# RUN: not llvm-objcopy --update-section=.text=%t.noexist %t /dev/null
+
----------------
This needs a diagnostic.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/update-section.test:69
+    SizeOfRawData:   0
+symbols:
+...
----------------
delete unused `symbols:`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118189/new/

https://reviews.llvm.org/D118189