[PATCH] D111984: [msan] Add stat-family interceptors on Linux

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added subscribers: thesamesam, MaskRay.
MaskRay added inline comments.


================
Comment at: compiler-rt/lib/msan/msan_interceptors.cpp:661
 
-#if SANITIZER_FREEBSD || SANITIZER_NETBSD
+#define SANITIZER_STAT_LINUX (SANITIZER_LINUX && __GLIBC_PREREQ(2, 33))
+#if SANITIZER_FREEBSD || SANITIZER_NETBSD || SANITIZER_STAT_LINUX
----------------
vitalybuka wrote:
> foobarrior wrote:
> > vitalybuka wrote:
> > > This condition is inconvenient
> > > I have false msan reports on 2.33 because it's compiled on older glibc
> > Hi Vitaly!
> > What's your setup?
> > And can you provide an exmple of false positive?
> https://lab.llvm.org/staging/#/builders/72/builds/1685/steps/9/logs/stdio
If `__GLIBC_PREREQ` is not defined (e.g. Linux musl), there will be a preprocessor error like:

* Clang: `error: function-like macro '__GLIBC_PREREQ' is not defined`
* GCC: `error: missing binary operator before token "("`

Looks like @thesamesam is trying to fix this for Linux musl.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111984/new/

https://reviews.llvm.org/D111984