[PATCH] D114737: [lld][Macho] Include dead-stripped symbols in mapfile
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 27 14:55:34 PST 2022
int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.
Nice!
================
Comment at: lld/MachO/MapFile.cpp:1
//===- MapFile.cpp --------------------------------------------------------===//
//
----------------
would be good to `brew install clang-format` :)
================
Comment at: lld/test/MachO/dead-strip.s:61
+# RUN: %t/no-dead-symbols.s -o %t/no-dead-symbols.o
+# RUN: %lld -lSystem -dead_strip -map %t/map \
+# RUN: %t/no-dead-symbols.o -o %t/no-dead-symbols
----------------
can we call this file something other than `map`? That way we're not overwriting the `map` emitted by the earlier command on line 11. That makes debugging the test easier since we can look in the output folder and see the preserved outputs from each command.
================
Comment at: lld/test/MachO/dead-strip.s:72
+# NODEADSYMBOLS-NEXT: # Address File Name
+# NODEADSYMBOLS-NEXT: END OF MAP
----------------
this could just be `NODEADSYMBOLS-EMPTY:`, then you wouldn't need the "END OF MAP"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114737/new/
https://reviews.llvm.org/D114737
More information about the llvm-commits
mailing list