[PATCH] D117951: [SLP] Optimize reschedule of previously scheduled bundle member [NFC]

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2599
+    void unschedule(ScheduleData *SD) {
+      assert(SD && SD->isSchedulingEntity() && SD->IsScheduled);
+      LLVM_DEBUG(dbgs() << "SLP:   unschedule " << *SD << "\n");
----------------
reames wrote:
> ABataev wrote:
> > Asserting message?
> Doesn't seem to add any value and we are inconsistent about them across codebase.
> 
> I really don't care here, if you want it added, please give me wording and I'll copy-and-paste.  
We try to add messages in a new/modified code.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2602-2603
+
+      SmallVector<ScheduleData*> Worklist;
+      Worklist.push_back(SD);
+
----------------
reames wrote:
> ABataev wrote:
> > `SmallVector<ScheduleData *> Worklist(1, SD);`
> Not idiomatic, and frankly, confusing.
We use this style of worklist initialization at least in SLP vectorizer. Plus, the code requires formatting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117951/new/

https://reviews.llvm.org/D117951