[PATCH] D118189: [llvm-objcopy][COFF] Implement --update-section

[Alex Brachet via Phabricator via llvm-commits]

abrachet marked 2 inline comments as done.
abrachet added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/update-section.test:20
+# NO-SECTION: error: {{.*}}could not find section with name '.noexist'
+
+--- !COFF
----------------
MaskRay wrote:
> Add a test for an `IMAGE_SCN_CNT_UNINITIALIZED_DATA` section like `.bss`. There should be an error similar to ELF `SHT_NOBITS`
This works because the data size is 0. Do you want an explicit check for `IMAGE_SCN_CNT_UNINITIALIZED_DATA`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118189/new/

https://reviews.llvm.org/D118189